[ML] Filtering category runtime fields in advanced wizard #132916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
commented
May 25, 2022
| @@ -16,6 +16,13 @@ import { | |||
| } from '../types/fields'; | |||
| import { ML_JOB_AGGREGATION } from '../constants/aggregation_types'; | |||
|
|
|||
| const categoryFieldTypes = [ | |||
There was a problem hiding this comment.
moving this into common
jgowdyelastic
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
May 25, 2022
qn895
approved these changes
May 25, 2022
|
Code LGTM 🎉 |
|
@peteharverson i've added sorting to all the field list dropdowns in c69a52d |
peteharverson
approved these changes
May 26, 2022
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
added
the
auto-backport
jgowdyelastic
deleted the
filtering-category-runtime-fields-in-advanced-wizard
branch
kibanamachine
pushed a commit
that referenced
this pull request
May 26, 2022
* [ML] Filtering category runtime fields in advanced wizard * reverting accidentally commited code * sorting fields in dropdowns * removing accidentally committed code (cherry picked from commit ad36a63)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 26, 2022
…132987) * [ML] Filtering category runtime fields in advanced wizard * reverting accidentally commited code * sorting fields in dropdowns * removing accidentally committed code (cherry picked from commit ad36a63) Co-authored-by: James Gowdy <jgowdy@elastic.co> Co-authored-by: Spencer <spencer@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using runtime fields in the advanced job wizard, category fields, e.g. keyword, text, should not be selectable as the detector's
field_name