Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Hide job messages clear notifications tooltip on click #132982

Merged

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented May 26, 2022

Summary

Fixes the onClick behavior of the 'Clear notificaitons' and Refresh buttons in the Job Messages tab of the Anomaly Detection jobs list, to hide the tooltip when the button is clicked.

The fix switches the blurButtonOnClick function to use event.currentTarget rather than event.target as currentTarget always refers to the element to which the event handler has been attached, as opposed to target which identifies the element on which the event occurred and which may be its descendant (as was the case for the Clear Notifications button where the event occured on the <span> element containing the button text.

Before:

job_messages_tooltip_before

After:

job_messages_tooltip

Checklist

Fixes #128734

@peteharverson peteharverson added review release_note:fix :ml Feature:Anomaly Detection ML anomaly detection auto-backport Deprecated: Automatically backport this PR after it's merged v8.3.0 v8.4.0 labels May 26, 2022
@peteharverson peteharverson requested a review from a team as a code owner May 26, 2022 09:22
@peteharverson peteharverson self-assigned this May 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +71.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 26, 2022
…#133019)

(cherry picked from commit a954553)

Co-authored-by: Pete Harverson <pete@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly detection job list - clear notifications button tooltip does not disappear
6 participants