Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling on precommit hook #132998

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented May 26, 2022

Summary

Today I had a filename case issue that made the precommit hook fail, but given the following error I could find out what was about:

git commit -m'blah blah'
 succ [eslint] 9 files linted successfully
ERROR UNHANDLED ERROR
ERROR TypeError: (0 , _devUtils.combineErrors) is not a function
          at description (./kibana/src/dev/run_precommit_hook.js:65:13)
          at processTicksAndRejections (node:internal/process/task_queues:96:5)
          at ./kibana/node_modules/@kbn/dev-cli-runner/target_node/run.js:62:7
          at withProcRunner (./kibana/node_modules/@kbn/dev-proc-runner/target_node/with_proc_runner.js:31:5)
          at run (./kibana/node_modules/@kbn/dev-cli-runner/target_node/run.js:61:5)
Pre-commit hook failed (add --no-verify to bypass)
  For eslint failures you can try running `node scripts/precommit_hook --fix`

The problem was due to the combineErrors function that has moved from the @kbn/dev-utils to the @kbn/dev-cli-errors.
With this fix the same execution reports:

succ [eslint] 9 files linted successfully
ERROR Filenames MUST use snake_case.
       - x-pack/plugins/lens/common/expressions/rename_columns/renameColumns_fn.ts

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Operations Team label for Operations Team release_note:fix auto-backport Deprecated: Automatically backport this PR after it's merged v8.3.0 v8.4.0 labels May 26, 2022
@dej611 dej611 requested a review from a team as a code owner May 26, 2022 12:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @brianseeders already fixed this in another PR but LGTM

@dej611
Copy link
Contributor Author

dej611 commented May 26, 2022

Let's wait for @brianseeders , I can close this if he has a better fix.

@brianseeders
Copy link
Contributor

My PR got reverted (for another reason), so feel free to merge this one.

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 26, 2022
) (#133010)

(cherry picked from commit d3ee891)

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: Spencer <spencer@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:fix Team:Operations Team label for Operations Team v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants