-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error handling on precommit hook #132998
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @brianseeders already fixed this in another PR but LGTM
Let's wait for @brianseeders , I can close this if he has a better fix. |
My PR got reverted (for another reason), so feel free to merge this one. |
) (cherry picked from commit d3ee891)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
Today I had a filename case issue that made the precommit hook fail, but given the following error I could find out what was about:
The problem was due to the
combineErrors
function that has moved from the@kbn/dev-utils
to the@kbn/dev-cli-errors
.With this fix the same execution reports:
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers