Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the term "upgraded" with "upgrading" #133138

Merged
merged 7 commits into from May 31, 2022
Merged

Replaced the term "upgraded" with "upgrading" #133138

merged 7 commits into from May 31, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2022

Summary

Resolve issue #116742
Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ghost ghost self-requested a review as a code owner May 30, 2022 13:22
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost ghost changed the title Replaced the term "upgraded" to "upgrading" Replaced the term "upgraded" with "upgrading" May 30, 2022
@nchaulet nchaulet self-assigned this May 30, 2022
@nchaulet nchaulet added v8.3.0 v8.4.0 bug Fixes for quality problems that affect the customer experience auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes labels May 30, 2022
…/components/agent_upgrade_modal/index.tsx

Co-authored-by: Nicolas Chaulet <n.chaulet@gmail.com>
@nchaulet
Copy link
Member

Buildkite, test this

@nchaulet
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@nchaulet
Copy link
Member

Buildkite, test this

@nchaulet
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@nchaulet nchaulet enabled auto-merge (squash) May 31, 2022 09:07
@nchaulet nchaulet merged commit 2d170f8 into elastic:main May 31, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 723.0KB 723.0KB +2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@ghost
Copy link
Author

ghost commented May 31, 2022

Thank you.

@ghost ghost deleted the upgrading-egent branch May 31, 2022 10:41
kibanamachine added a commit that referenced this pull request May 31, 2022
…fications (#133138) (#133194)

(cherry picked from commit 2d170f8)

Co-authored-by: Najmieh Sadat <98463228+najmiehsa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants