Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass decorated server to routes #133264

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Pass decorated server to routes #133264

merged 1 commit into from
Jun 1, 2022

Conversation

klacabane
Copy link
Contributor

Summary

Wondered why debug logs stayed empty :)

@klacabane klacabane added release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels May 31, 2022
@klacabane klacabane requested a review from a team as a code owner May 31, 2022 23:03
@klacabane klacabane self-assigned this May 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @klacabane

matschaffer
matschaffer approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spotting.

@klacabane klacabane merged commit 7965324 into elastic:main Jun 1, 2022
@weltenwort
Copy link
Member

oops, sorry about this 🙈 thanks for fixing it

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133264 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 3, 2022
@weltenwort weltenwort added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jun 3, 2022
@weltenwort
Copy link
Member

IMHO this bugfix should go into 8.3, so I enabled the auto-backport

@kibanamachine kibanamachine mentioned this pull request Jun 3, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 3, 2022
@klacabane
pass decorated server to routes (#133264)
7ef4373 
(cherry picked from commit 7965324)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 3, 2022
@kibanamachine @klacabane
pass decorated server to routes (#133264) (#133496)
878bcca 
(cherry picked from commit 7965324)

Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

Assignees

@klacabane klacabane

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@klacabane @elasticmachine @kibana-ci @weltenwort @kibanamachine @matschaffer