-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Markdown element auto-applies text changes. #133318
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally + code review - everything works great! Left one tiny clarification question, but it's not a blocker 👍
x-pack/plugins/canvas/public/components/with_debounce_arg/with_debounce_arg.tsx
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
@elastic/kibana-presentation - Do you think its prudent to add an unit/ functional test to such UI changes ? Apply button has been removed and the monaco editor auto saves everything now . plz advice...Thankyou. |
Summary
Closes: #125999
editor
argument, which is renderingmonaco
code editor with markdown syntax highlighting and auto-applying of the text changes.withDebouncedArg
to handle the changed argument from within the expression.Testing notes
Screen.Recording.2022-06-01.at.18.03.11.mov