Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Markdown element auto-applies text changes. #133318

Merged
merged 6 commits into from
Jun 10, 2022

Conversation

Kuznietsov
Copy link
Contributor

Summary

Closes: #125999

  • Added editor argument, which is rendering monaco code editor with markdown syntax highlighting and auto-applying of the text changes.
  • Added the ability for withDebouncedArg to handle the changed argument from within the expression.

Testing notes

Screenshot 2022-06-01 at 18 00 49

Screen.Recording.2022-06-01.at.18.03.11.mov

@Kuznietsov Kuznietsov added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This commit does not require backporting NeededFor:Canvas Feature:Canvas v8.3.0 labels Jun 1, 2022
@Kuznietsov Kuznietsov self-assigned this Jun 1, 2022
@Kuznietsov Kuznietsov added this to In progress in Canvas via automation Jun 1, 2022
@Kuznietsov Kuznietsov added v8.4.0 and removed v8.3.0 labels Jun 1, 2022
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov marked this pull request as ready for review June 2, 2022 06:53
@Kuznietsov Kuznietsov requested a review from a team as a code owner June 2, 2022 06:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Heenawter Heenawter self-requested a review June 9, 2022 15:43
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally + code review - everything works great! Left one tiny clarification question, but it's not a blocker 👍

Canvas automation moved this from In progress to Reviewer approved Jun 9, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1138 1139 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov merged commit d52b866 into elastic:main Jun 10, 2022
Canvas automation moved this from Reviewer approved to Done Jun 10, 2022
@rashmivkulkarni
Copy link
Contributor

rashmivkulkarni commented Aug 8, 2022

@elastic/kibana-presentation - Do you think its prudent to add an unit/ functional test to such UI changes ? Apply button has been removed and the monaco editor auto saves everything now . plz advice...Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort NeededFor:Canvas release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.4.0
Projects
No open projects
Canvas
  
Done
Development

Successfully merging this pull request may close these issues.

Canvas markdown element should auto-apply text changes
6 participants