Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actionable Observability][BUG] Fix connectors doesn't appear in the Rule Details page after creating first connector #133737

Merged
merged 9 commits into from
Jun 8, 2022
Merged

[Actionable Observability][BUG] Fix connectors doesn't appear in the Rule Details page after creating first connector #133737

merged 9 commits into from
Jun 8, 2022

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented Jun 7, 2022 •
edited
Loading

Summary

it fixes #133515 by updating the hook to make it returns only the rule actions.

Before, the hook is returning all the actions connectors even the ones that are NOT related to the given rule.
Now:

  • The hook compares all exiting action connectors with the rule action connectors and returns the intersection between these two lists.
  • Show No Actions when the connector is deleted from the Rule and Connectors page.

@fkanout fkanout added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 v8.4.0 labels Jun 7, 2022
@fkanout fkanout self-assigned this Jun 7, 2022
@fkanout
Copy link
Contributor Author

fkanout commented Jun 7, 2022

@elasticmachine merge upstream

@fkanout fkanout marked this pull request as ready for review June 7, 2022 13:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@fkanout fkanout requested a review from a team June 7, 2022 13:05
@fkanout fkanout added v8.3.1 and removed auto-backport Deprecated: Automatically backport this PR after it's merged v8.3.0 labels Jun 7, 2022
@fkanout
Copy link
Contributor Author

fkanout commented Jun 7, 2022

@elasticmachine merge upstream

@mgiota mgiota self-requested a review June 8, 2022 07:40
mgiota
mgiota approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkanout I had seen this error before, it was very random and I couldn't always reproduce. Nice work here finding the root of the problem and giving exact steps to reproduce!

I tested it locally and the issue is fixed. I followed the steps in your issue description and issue is not reproducible anymore. Action connectors are always being updated now!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 495.8KB 496.0KB +212.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

@fkanout fkanout merged commit 44026a5 into elastic:main Jun 8, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

22 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 133737 locally

@fkanout fkanout added the auto-backport Deprecated: Automatically backport this PR after it's merged label Aug 10, 2022
kibanamachine pushed a commit that referenced this pull request Aug 10, 2022
@fkanout
[Actionable Observability][BUG] Fix connectors doesn't appear in the …
25502e1 
…Rule Details page after creating first connector (#133737)

* Move rule actions to the hook which is right call

* Update naming

* Fix when a connector is deleted from connector page  in Stack Management

* Fix tests

* Update tests and mock loadAllActions API

* Remove unused import

* Call the connectors API only when the rule has actions

(cherry picked from commit 44026a5)
@kibanamachine kibanamachine mentioned this pull request Aug 10, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@kibanamachine kibanamachine added v8.3.4 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 10, 2022
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 10, 2022
@kibanamachine @fkanout
[Actionable Observability][BUG] Fix connectors doesn't appear in the …
10a06de 
…Rule Details page after creating first connector (elastic#133737) (elastic#138484)

* Move rule actions to the hook which is right call

* Update naming

* Fix when a connector is deleted from connector page  in Stack Management

* Fix tests

* Update tests and mock loadAllActions API

* Remove unused import

* Call the connectors API only when the rule has actions

(cherry picked from commit 44026a5)

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiota mgiota mgiota approved these changes

Assignees

@fkanout fkanout

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.1 v8.3.4 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][Actionable Observability] First newly created connector doesn't appear in the Rule Details page.
5 participants
@fkanout @elasticmachine @kibana-ci @kibanamachine @mgiota