Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML ]API integration tests for max_anomaly_score endpoint #133776

Merged
merged 6 commits into from
Jun 7, 2022
Merged

[ML ]API integration tests for max_anomaly_score endpoint #133776

merged 6 commits into from
Jun 7, 2022

Conversation

darnautov
Copy link
Contributor

Summary

Part of #130648

API integration tests for the max_anomaly_score endpoint.

Checklist

@darnautov darnautov added :ml Feature:Anomaly Detection ML anomaly detection test-api-integration auto-backport Deprecated: Automatically backport this PR after it's merged Team:ML Team label for ML (also use :ml) v8.3.0 v8.4.0 labels Jun 7, 2022
@darnautov darnautov requested a review from a team as a code owner June 7, 2022 14:52
@darnautov darnautov self-assigned this Jun 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Jun 7, 2022
@darnautov darnautov requested a review from pheyos June 7, 2022 15:43
@darnautov darnautov mentioned this pull request Jun 7, 2022
Closed
4 tasks
pheyos
pheyos approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the suite name (I'll be out tomorrow, so feel free to merge with or without changing the suite name).

peteharverson
peteharverson approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise LGTM

x-pack/test/api_integration/apis/ml/results/max_anomaly_score.ts Outdated
ml.api.assertResponseStatusCode(200, status, body);
expect(body.maxScore).to.be.above(50);
});
it('should response with an error when job with provided id does not exist', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - should respond with an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in e7f4d95

@darnautov darnautov enabled auto-merge (squash) June 7, 2022 17:12
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 3902b17 into elastic:main Jun 7, 2022
@kibanamachine kibanamachine mentioned this pull request Jun 7, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 7, 2022
@darnautov
[ML ]API integration tests for max_anomaly_score endpoint (#133776)
ac75608 
* max_anomaly_score tests

* 404 test

* remove tag

* fix group name and a typo

(cherry picked from commit 3902b17)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 7, 2022
@kibanamachine @darnautov
[ML ]API integration tests for max_anomaly_score endpoint (#133776) (…
034ed36 
…#133820)

* max_anomaly_score tests

* 404 test

* remove tag

* fix group name and a typo

(cherry picked from commit 3902b17)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test-api-integration v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson