[Discover] Include current filters into "Test query" request #134184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
brianseeders
added
backport:prev-minor
kertal
reviewed
Jun 14, 2022
Comment on lines
+39
to
+43
| setTestQueryResponse({ | ||
| result: null, | ||
| error: null, | ||
| isLoading: true, | ||
| }); |
kertal
reviewed
Jun 14, 2022
| testSearchSource.setField( | ||
| 'filter', | ||
| timeFilter ? [timeFilter, ...ruleConfiguration.filter] : ruleConfiguration.filter | ||
| ); | ||
| const { rawResponse } = await firstValueFrom(testSearchSource.fetch$()); |
There was a problem hiding this comment.
qq @Dosant, unrelated to what we fix with this PR, but this should be changed to lastValueFrom, right?
kertal
approved these changes
Jun 14, 2022
|
note that we might have to change the observable handling ... but this could also be done in a follow up |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 14, 2022
#134323) * [Discover] Include current filters into "Test query" request * [Discover] Reset query results when criteria is changed * [Discover] Add a comment * [Discover] Reset "Test query" when any rule configuration changes (cherry picked from commit 7b17093) Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134180
Summary
This PR fixes "Test query" button when user changes current Rule filters.
It also removes number of matches from a previous test run if configuration (query, filter, etc) was updated. This way user would be confused whether it's a previous calculation or a new one.
Steps to test: