Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] [Reporting] Remove controls from reports #134240

Merged
merged 2 commits into from
Jun 15, 2022
Merged

[Controls] [Reporting] Remove controls from reports #134240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6a66b7
Remove data-shared-items-count from controls
Heenawter Jun 13, 2022
cebadc8
Merge branch 'main' into fix-controls-report-bug_2022-06-09
Heenawter Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/plugins/controls/public/control_group/component/control_group_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export const ControlGroup = () => {
responsive={false}
alignItems="center"
data-test-subj="controls-group"
data-shared-items-count={idsInOrder.length}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change actually "Remove controls from reports"? Or does it simply fix the loading issue we were encountering before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it does remove controls from reports (specifically, non-print-optimized reports) - they used to be screen captured and included in these reports, and now they are not and the reports only include the graphs on the dashboard. I could change the title to reflect that this only impacts non-print-optimized reports?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I didn't realise that simply removing the data-shared-items-count would actually remove the Controls from the report! In that case the title makes total sense. Thanks for the response!

>
<EuiFlexItem>
<DndContext
Expand Down