Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Introduce Alerts tab on service overview page #134350

Merged
merged 18 commits into from Jul 7, 2022
Merged

[APM] Introduce Alerts tab on service overview page #134350

merged 18 commits into from Jul 7, 2022

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jun 14, 2022 •
edited

Summary

#128858

In this PR we introduce a the alerts tab on the service overview page. The alerts are filtered by the service name and the environment.

The sharable table (which comes for free from the Response ops team) it offers limited features.
Please refer on the ticket Missing features from the sharable table for more details

Preview

Screen.Recording.2022-07-07.at.17.22.58.mov

TODO

  • format duration and timestamp

@kpatticha kpatticha marked this pull request as ready for review June 22, 2022 11:42
@kpatticha kpatticha requested a review from a team as a code owner June 22, 2022 11:42
@kpatticha
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kpatticha kpatticha added release_note:feature Makes this part of the condensed release notes v8.4.0 labels Jun 22, 2022
@kpatticha kpatticha changed the title Introduce Alerts tab on service overview page [APM] Introduce Alerts tab on service overview page Jun 22, 2022
@kpatticha kpatticha linked an issue Jun 22, 2022 that may be closed by this pull request
[APM] Show alerts in context of a service #128858
Closed
4 tasks
@XavierM XavierM mentioned this pull request Jun 27, 2022
Merged
1 task
@gbamparop gbamparop self-requested a review July 6, 2022 12:05
ogupte
ogupte suggested changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small changes, but overall looks great!

...lugins/apm/public/components/alerting/service_overview_alerts/alerts_table_status_filter.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx Outdated Show resolved Hide resolved
gbamparop
gbamparop reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I've added some comments on the PR.

x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx Outdated Show resolved Hide resolved
...lugins/apm/public/components/alerting/service_overview_alerts/alerts_table_status_filter.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx Outdated Show resolved Hide resolved
@kpatticha kpatticha force-pushed the 128858-alert-tab branch 3 times, most recently from 38754d5 to ac0c9ab Compare July 7, 2022 10:45
ogupte
ogupte approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gbamparop
gbamparop approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 !

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1300 1302 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 27.9KB 28.1KB +258.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 23c314d into elastic:main Jul 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 7, 2022
@kpatticha kpatticha mentioned this pull request Aug 1, 2022
Closed
@kpatticha kpatticha added apm:test-plan-done Pull request that was successfully tested during the test plan apm:test-plan-8.4.0 APM UI - Test Plan for v8.4.0 labels Aug 4, 2022
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
@neptunian neptunian mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@gbamparop gbamparop gbamparop approved these changes

Assignees
No one assigned
Labels
apm:test-plan-8.4.0 APM UI - Test Plan for v8.4.0 apm:test-plan-done Pull request that was successfully tested during the test plan backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Show alerts in context of a service
7 participants
@kpatticha @elasticmachine @kibana-ci @ogupte @gbamparop @tylersmalley @kibanamachine