[Lens] Dont let reference line fills on different axes collide #135299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
mbondyra
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
I tried to reproduce the second issue both here and on main, but failed this time... Maybe I had missed an important detail when creating the issue, but cannot reproduce now. Will reopen if I figure it out 😅
Tested the solution and works great -simple and effective 👌🏼
yakhinvadim
pushed a commit
to yakhinvadim/kibana
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134803
Fixes #135024
This PR only considers other reference lines with a same direction fill for overlaps if they are on the same axis.
I'm not sure about the second bug (could you check that again @mbondyra ) but I couldn't reproduce this issue on this branch.
Maybe I misunderstood something about the repo.