[RAM] Allow wildcard search on rule's name and tags #136312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
release_note:fix
Team:ResponseOps
…ldcard-search-rules
…ldcard-search-rules
…ldcard-search-rules
…rM/kibana into 131230-allow-wildcard-search-rules
|
Pinging @elastic/response-ops (Team:ResponseOps) |
1 task
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jcger
approved these changes
Jul 20, 2022
| let optionsFilter: KueryNode | string | null = filter ?? null; | ||
| try { | ||
| if (optionsFilter != null && typeof optionsFilter === 'string') { | ||
| // FUTURE ENGINEER -> if I can parse it that mean it is a KueryNode or it is a string |
There was a problem hiding this comment.
instead of the comment you could create a function with a descriptive name like isKueryNodeOrString, up to you
| optionsFilter = JSON.parse(optionsFilter); | ||
| } | ||
| } catch (e) { | ||
| optionsFilter = filter ?? null; |
There was a problem hiding this comment.
at this point optionsFilter has already the same value so you might consider removing this line or the assignation in line 11
EricDavisX
approved these changes
Jul 20, 2022
gmmorris
added
the
Feature:Alerting/RulesManagement
tylersmalley
added
ci:cloud-deploy
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #131230
This PR will allow our user to use wildcard to find rule's name and tag without crashing the application. if we want to find rule with just few letter and without using wildcard, we will have to implement N-gram tokenizer on the saved object to allow this kind of search.
Checklist