[APM] e2e tests fix (Comparison feature flag) #137209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
cauemarcondes
added
release_note:skip
cauemarcondes
changed the title
8 tasks
kpatticha
reviewed
Aug 2, 2022
| @@ -8,13 +8,14 @@ | |||
| declare namespace Cypress { | |||
| interface Chainable { | |||
| loginAsViewerUser(): void; | |||
| loginAsEditorUser(): void; | |||
| loginAsEditorUser(): Promise<Cypress.Response<any>>; | |||
There was a problem hiding this comment.
I expect also the other loginAs* functions to return a promise. Do you think it make sense to update them?
|
Pinging @elastic/apm-ui (Team:apm) |
kpatticha
approved these changes
Aug 2, 2022
sorenlouv
reviewed
Aug 2, 2022
| }, | ||
| }); | ||
| } | ||
| ); |
There was a problem hiding this comment.
Much better to do it via the api 👍 It felt like we were writing e2e tests for Advanced settings before.
|
buildkite test this |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.5.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the tests by removing the dependency on each other state. I also created a new
commandto update values in the Advanced settings, we no longer need to navigate there to update a value.