Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug with PR #13854 #13873

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Conversation

simianhacker
Copy link
Member

This PR fixes a bug with PR #13854 where when the user types in an invalid interval pattern the screen goes blank because visData ends up being undefined. This PR ensures there is always a visData and model object.

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 v6.0.0-rc1 v7.0.0 labels Sep 6, 2017
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, I didn't realize something was up.. thx for follow up.

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simianhacker simianhacker merged commit 52cee7d into elastic:master Sep 7, 2017
simianhacker added a commit that referenced this pull request Sep 7, 2017
simianhacker added a commit that referenced this pull request Sep 7, 2017
@simianhacker
Copy link
Member Author

Back ported to 6.0 with bef94cb
Back ported to 6.x with 2391b7c

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
@simianhacker simianhacker deleted the fix-13854 branch April 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0-rc1 v6.0.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants