tabify responeHandler for table #13877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Visualizations
|
jenkins, test this |
|
this will need a rebase to get the new license check in. can you create an improvement ticket for replacing the tagcloud/regionmap response handlers? |
ppisljar
force-pushed
the
refactor/table
branch
from
4ac0c1b
to
fdcdad0
Compare
|
@thomasneirynck i created an issue to track tag cloud and region map progress: #13940 |
|
Disregard. My kibana instance died so thats why the client was choking.
|
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
thomasneirynck
approved these changes
Sep 12, 2017
|
lgtm pending green CI. markdown failure seems like a fluke. |
|
jenkins, test this |
ppisljar
force-pushed
the
refactor/table
branch
from
fdcdad0
to
a97dfdb
Compare
ppisljar
added a commit
that referenced
this pull request
Sep 19, 2017
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
ppisljar
added a commit
that referenced
this pull request
Sep 19, 2017
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Sep 19, 2017
This reverts commit 622dd36.
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
* adding tabify response handler * tabify should be the default response handler * asAggResultConfig should be configurable for BWC * update table to work with new tabify response handler * region map needs to define responseHandler: none * fixing tests * markdown should set responseHandler to none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table should not import tabify but should use tabify respose handler.
tag cloud and region map should probably do the sameactually both should be using point series response handler with dimensions like x for text and y for font size (text, color for regionmap) ... we should avoid using pure es data in visualizations