Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "compatibility" rather than "availability" on connectors table #139024

Merged
merged 11 commits into from
Aug 26, 2022
Merged

Use "compatibility" rather than "availability" on connectors table #139024

merged 11 commits into from
Aug 26, 2022

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Aug 17, 2022 •
edited by kibanamachine
Loading

Fixes: #138015

This PR intends to make "availability" column on connectors table more understandable user friendly by replacing the column title "availability" with "compatibility" and simplifying the availability labels.

Uptime, Alerting, Security Solution and Cases labels are simplified by reduced to Alerting Rules and Cases

@ersin-erdal ersin-erdal added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.4.0 v8.5.0 release_note:fix labels Aug 17, 2022
@ersin-erdal ersin-erdal changed the title Use compatibility rather than availability on connectors table Use "compatibility" rather than "availability" on connectors table Aug 18, 2022
@ersin-erdal ersin-erdal marked this pull request as ready for review August 18, 2022 10:32
@ersin-erdal ersin-erdal requested a review from a team as a code owner August 18, 2022 10:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@EricDavisX EricDavisX added the ci:cloud-deploy Create or update a Cloud deployment label Aug 18, 2022
@ymao1
Copy link
Contributor

ymao1 commented Aug 22, 2022

We're currently showing "Availability" in the "Add Connector" flyout header. Should this be changed to Compatibility as well?
Screen Shot 2022-08-22 at 8 42 45 AM

@pmuellr
Copy link
Member

pmuellr commented Aug 22, 2022

hehe, I just noticed what Ying noticed in the Add Connector flyout while testing; seems to me that yes, this should be changed in the same way as with the Connectors list.

@ersin-erdal ersin-erdal added v8.4.1 and removed v8.4.0 labels Aug 23, 2022
@ersin-erdal
Copy link
Contributor Author

We're currently showing "Availability" in the "Add Connector" flyout header. Should this be changed to Compatibility as well? Screen Shot 2022-08-22 at 8 42 45 AM

Yes, renamed that too, thanks for pointing out :)

ymao1
ymao1 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected.

doakalexi
doakalexi approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1 ymao1 added v8.4.2 and removed v8.4.1 labels Aug 25, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
actions 261 267 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.0MB 1.0MB +119.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
actions 16.2KB 16.7KB +466.0B
Unknown metric groups

API count

id before after diff
actions 266 272 +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ersin-erdal ersin-erdal merged commit 5cb0c01 into elastic:main Aug 26, 2022
@ersin-erdal ersin-erdal deleted the 138015-availability-label branch August 26, 2022 12:37
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.4 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 139024

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 30, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 139024 locally

@ymao1 ymao1 mentioned this pull request Aug 31, 2022
Merged
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 139024 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 139024 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 139024 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 139024 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 139024 locally

Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@ersin-erdal @Mpdreamz
Use "compatibility" rather than "availability" on connectors table (e…
7155bcf 
…lastic#139024)

* Use compatibility rather than availability on connectors table
* Replace Availability with Compatibility in create connector flyout.
@ersin-erdal ersin-erdal mentioned this pull request Sep 6, 2022
Merged
@ersin-erdal
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ersin-erdal added a commit to ersin-erdal/kibana that referenced this pull request Sep 6, 2022
@ersin-erdal
Use "compatibility" rather than "availability" on connectors table (e…
fb54350 
…lastic#139024)

* Use compatibility rather than availability on connectors table
* Replace Availability with Compatibility in create connector flyout.

(cherry picked from commit 5cb0c01)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/sections/actions_connectors_list/components/actions_connectors_list.test.tsx
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 6, 2022
ersin-erdal added a commit that referenced this pull request Sep 6, 2022
@ersin-erdal @kibanamachine
[8.4] Use "compatibility" rather than "availability" on connectors ta…
aad5ef1 
…ble (#139024) (#140114)

* Use "compatibility" rather than "availability" on connectors table (#139024)

* Use compatibility rather than availability on connectors table
* Replace Availability with Compatibility in create connector flyout.

(cherry picked from commit 5cb0c01)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/sections/actions_connectors_list/components/actions_connectors_list.test.tsx

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@doakalexi doakalexi doakalexi approved these changes

Assignees
No one assigned
Labels
ci:cloud-deploy Create or update a Cloud deployment Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.4.2 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connectors Stack Management tab shows 'Availability' labels that need clarification
8 participants
@ersin-erdal @elasticmachine @ymao1 @pmuellr @kibana-ci @kibanamachine @doakalexi @EricDavisX