Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Corrects file.path field name in v3_windows_anomalous_script job #139109

Merged
merged 4 commits into from
Aug 23, 2022
Merged

[ML] Corrects file.path field name in v3_windows_anomalous_script job #139109

merged 4 commits into from
Aug 23, 2022

Conversation

VSpoon
Copy link
Contributor

@VSpoon VSpoon commented Aug 18, 2022 •
edited by peteharverson
Loading

Summary

Corrects the file.path field name in the v3_windows_anomalous_script job in the Security:Windows set of pre-configured anomaly detection jobs. Previously file.Path was incorrectly used, which prevented the ML job from running. file.Path is not a valid field and hence not mapped thus preventing the data feed from starting.

@VSpoon
Update v3_windows_anomalous_script.json
2f0e892 
Fixed file.Path as it prevents the ML job from running.
@VSpoon VSpoon requested a review from a team as a code owner August 18, 2022 15:39
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@VSpoon
Copy link
Contributor Author

VSpoon commented Aug 18, 2022

@ajosh0504 recreated pull request in regards to #138749

Thanks,

ajosh0504
ajosh0504 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@peteharverson peteharverson changed the title Update v3_windows_anomalous_script.json [ML] Corrects file.path field name in v3_windows_anomalous_script job Aug 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

@elasticmachine merge upstream

@peteharverson
Copy link
Contributor

buildkite test this

peteharverson
peteharverson approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson
Copy link
Contributor

buildkite test this

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peteharverson
Copy link
Contributor

run elasticsearch-ci/docs

@peteharverson peteharverson merged commit 6e5bc57 into elastic:main Aug 23, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2022
@peteharverson peteharverson added backport pending and removed backport:skip This commit does not require backporting labels Aug 23, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2022
@peteharverson
Copy link
Contributor

@VSpoon I have merged this PR for 8.5.0, and will also backport for 8.4.1. Many thanks for contributing this fix.

@peteharverson peteharverson added v8.4.2 auto-backport Deprecated: Automatically backport this PR after it's merged labels Aug 31, 2022
kibanamachine pushed a commit that referenced this pull request Aug 31, 2022
@VSpoon
Update v3_windows_anomalous_script.json (#139109)
785bd01 
Fixed file.Path as it prevents the ML job from running.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Pete Harverson <pete@elastic.co>
(cherry picked from commit 6e5bc57)
@kibanamachine kibanamachine mentioned this pull request Aug 31, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Aug 31, 2022
@kibanamachine @VSpoon
Update v3_windows_anomalous_script.json (#139109) (#139817)
4dfa712 
Fixed file.Path as it prevents the ML job from running.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Pete Harverson <pete@elastic.co>
(cherry picked from commit 6e5bc57)

Co-authored-by: VSpoon <38534966+VSpoon@users.noreply.github.com>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@VSpoon @kibanamachine
@peteharverson @Mpdreamz
Update v3_windows_anomalous_script.json (elastic#139109)
7d0a626 
Fixed file.Path as it prevents the ML job from running.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Pete Harverson <pete@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@ajosh0504 ajosh0504 ajosh0504 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged backport:skip This commit does not require backporting 💝community Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.4.2 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VSpoon @kibanamachine @elasticmachine @peteharverson @kibana-ci @ajosh0504