Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task health calculation never returns Error or Warning but logs the HealthStatus #139274

Merged
merged 3 commits into from Aug 25, 2022

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Aug 23, 2022

fixes: #138344

This PR changes Health Status api to always return "OK" but log a message when error or warn thresholds are exceeded.
So, Kibana would be prevented from ending up in a degraded status.

@ersin-erdal ersin-erdal added release_note:fix Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0 labels Aug 23, 2022
@ersin-erdal ersin-erdal added v8.4.0 and removed v8.4.0 labels Aug 23, 2022
@ersin-erdal ersin-erdal marked this pull request as ready for review August 23, 2022 18:40
@ersin-erdal ersin-erdal requested a review from a team as a code owner August 23, 2022 18:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doakalexi doakalexi self-requested a review August 24, 2022 13:30
Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ersin-erdal ersin-erdal merged commit 7b4b2be into elastic:main Aug 25, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 25, 2022
@ersin-erdal ersin-erdal deleted the 138344-health-status branch August 25, 2022 15:24
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
…ealthStatus (elastic#139274)

* Task health calculation never returns Error or Warning but logs the HealthStatus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps] large number of failed rule executions from space deleting leaves Kibana at a warning level
6 participants