Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Remove exclamation circle icon #139686

Merged
merged 3 commits into from Aug 31, 2022
Merged

[TSVB] Remove exclamation circle icon #139686

merged 3 commits into from Aug 31, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #139396

by removing the exclamation circle entry from the list of icons and migrating existing instances to exclamation triangle (which is what's shown in the chart anyway already)

I used these saved objects to test: https://gist.github.com/flash1293/b9fbba2bf1f7f82db7238da6555bc31a

@flash1293 flash1293 added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:skip This commit does not require backporting labels Aug 30, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 459.8KB 459.6KB -212.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review August 30, 2022 09:46
@flash1293 flash1293 requested a review from a team as a code owner August 30, 2022 09:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

mbondyra
mbondyra reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe I am not getting something but if I use [Flights] Delays & Cancellations, change it on main to exclamation circles for annotations, and move to your PR, it gives me asterisks, not triangles:

Screenshot 2022-08-30 at 18 55 10

@flash1293
Copy link
Contributor Author

@mbondyra are you sure it's running the migration again when switching? If your saved object already says 8.5.0 then it won't run the migration again and it will just select the first one in the list of icons (because the saved object still says exclamation circle)

mbondyra
mbondyra approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, forgot about migration working the way you explained. Checked again and everything works fine 👌🏼
Approved!

@flash1293 flash1293 merged commit d0c1cae into elastic:main Aug 31, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@flash1293 @Mpdreamz
[TSVB] Remove exclamation circle icon (elastic#139686)
3688479 
* remove exclamation circle

* fix snapshot file

* fix i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSVB Exclamation Triangle and Exclamation Circle have the same symbol
5 participants
@flash1293 @kibana-ci @elasticmachine @mbondyra @kibanamachine