Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Do not load all data views on broken data view reference #139690

Merged
merged 1 commit into from Aug 31, 2022
Merged

[Lens] Do not load all data views on broken data view reference #139690

merged 1 commit into from Aug 31, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #139082

By breaking out of the loop if a functioning data view has been found.

See issue for how to test this in the UI

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting labels Aug 30, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review August 30, 2022 09:45
@flash1293 flash1293 requested a review from a team as a code owner August 30, 2022 09:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

mbondyra
mbondyra reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be approved because the behavior is correct loading wise, but there's still a problem with data views:

  1. Create a vis like this one:

Screenshot 2022-08-31 at 10 14 30

2. Remove used data view 3. Go back to Lens without refreshing the page:

Screenshot 2022-08-31 at 10 15 21

Things stabilize when you refresh the page:
Screenshot 2022-08-31 at 10 13 44

@flash1293
Copy link
Contributor Author

Good catch @mbondyra , I think there is some cache foo going on. Could you open a new issue for that problem?

@flash1293 flash1293 merged commit 5e86ffa into elastic:main Aug 31, 2022
@mbondyra mbondyra mentioned this pull request Aug 31, 2022
Closed
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@flash1293 @Mpdreamz
do not load all data views (elastic#139690)
4252c80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra left review comments

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] On missing data view all data views are loaded and initialized
6 participants
@flash1293 @kibana-ci @elasticmachine @dej611 @mbondyra @kibanamachine