Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Add time marker setting for time axis #139950

Merged
merged 6 commits into from Sep 6, 2022
Merged

[Lens] Add time marker setting for time axis #139950

merged 6 commits into from Sep 6, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 1, 2022 •
edited

Closes #138384

Summary

This PR adds a new toggle to time axis to enable current time marker (disabled by default).

Sep-05-2022 16-51-02

Checklist

@jughosta jughosta added Feature:Lens backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.5.0 labels Sep 1, 2022
@jughosta jughosta self-assigned this Sep 1, 2022
@jughosta jughosta added release_note:enhancement and removed release_note:feature Makes this part of the condensed release notes labels Sep 1, 2022
@jughosta jughosta marked this pull request as ready for review September 5, 2022 16:04
@jughosta jughosta requested a review from a team as a code owner September 5, 2022 16:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor Author

jughosta commented Sep 6, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 527 528 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +794.0B
Unknown metric groups

API count

id before after diff
lens 613 614 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

flash1293
flash1293 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM!

@jughosta jughosta merged commit 0715e77 into elastic:main Sep 6, 2022
@jughosta jughosta deleted the 138384-lens-expose-time-marker branch September 6, 2022 11:19
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@jughosta @kibanamachine @Mpdreamz
[Lens] Add time marker setting for time axis (elastic#139950)
2c0b57d 
* [Lens] Add time marker setting for time axis

* [Lens] Update code style

* [Lens] Update tests

* [Lens] Update layout

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Expose time marker setting for time axis
5 participants
@jughosta @elasticmachine @kibana-ci @flash1293 @kibanamachine