Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variables in URL Drilldown title #140076

Merged
merged 5 commits into from Sep 20, 2022
Merged

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Sep 6, 2022

Summary

Closes #96322

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@vadimkibana vadimkibana marked this pull request as ready for review September 8, 2022 14:23
@vadimkibana vadimkibana requested a review from a team as a code owner September 8, 2022 14:23
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Sep 8, 2022
@vadimkibana vadimkibana added review release_note:feature Makes this part of the condensed release notes Team:AppServicesUx v8.5.0 and removed Feature:Drilldowns Embeddable panel Drilldowns labels Sep 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@vadimkibana vadimkibana changed the title allow variables in URL Drilldown title Allow variables in URL Drilldown title Sep 9, 2022
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a try. Works :)

@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Sep 9, 2022
@vadimkibana vadimkibana added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment labels Sep 20, 2022
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 20, 2022

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActionsEnhanced 22.2KB 22.3KB +138.0B
urlDrilldown 15.0KB 15.3KB +330.0B
total +468.0B
Unknown metric groups

API count

id before after diff
uiActionsEnhanced 205 206 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit 532d644 into elastic:main Sep 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment Feature:Drilldowns Embeddable panel Drilldowns release_note:feature Makes this part of the condensed release notes review v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[drilldown] Support variables in text menu
5 participants