[vis/requesting] only call when actually requesting #14017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix-requesting
branch
3 times, most recently
from
1a1fa17
to
b4fae2b
Compare
spalger
force-pushed
the
fix-requesting
branch
from
b4fae2b
to
4455170
Compare
nreese
approved these changes
Sep 16, 2017
| @@ -41,7 +53,7 @@ describe('SegmentedRequestProvider', () => { | |||
|
|
|||
| function mockSource() { | |||
| return { | |||
| get: sinon.stub().returns(mockIndexPattern()) | |||
| get: sinon.stub().returns(mockIndexPattern()), | |||
There was a problem hiding this comment.
I added a line below it at one point and deleted it later
stacey-gammon
approved these changes
Sep 20, 2017
| $scope.searchSource.onRequestStart(() => { | ||
| return $scope.vis.requesting(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I think this can be shortened to $scope.searchSource.onRequestStart($scope.vis.requesting);?
There was a problem hiding this comment.
Calling vis.requesting without it's this context might work, but seems like an unnecessary risk.
|
|
||
| return Promise | ||
| .map(this._requestStartHandlers, fn => fn(this, request)) | ||
| .then(_.noop); |
There was a problem hiding this comment.
How come you need this .then(_.noop) part?
There was a problem hiding this comment.
Documented the method as returning Promise<undefined> and realized that it was actually returning Promise<Array<WhateverStartHandlersReturn>>, so I used _.noop to actually resolve to undefined.
spalger
added a commit
that referenced
this pull request
Sep 22, 2017
* [vis/requesting] only call when actually requesting * [courier/dataSource] use Promise.map to catch sync errors * [courier/request] move source mutation logic out of request (cherry picked from commit b0dc246)
spalger
added a commit
that referenced
this pull request
Sep 22, 2017
* [vis/requesting] only call when actually requesting * [courier/dataSource] use Promise.map to catch sync errors * [courier/request] move source mutation logic out of request (cherry picked from commit b0dc246)
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
* [vis/requesting] only call when actually requesting * [courier/dataSource] use Promise.map to catch sync errors * [courier/request] move source mutation logic out of request
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
* [vis/requesting] only call when actually requesting * [courier/dataSource] use Promise.map to catch sync errors * [courier/request] move source mutation logic out of request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was talking with @nreese and learned that
vis.requesting()is being called in multiple places because the hook is actually triggered on serialization, which happens multiple times in some cases. This makes the relationship betweenvis.requesting()and the search source more explicit by adding adataSource.onRequestStart()hook which is called before any courier request is started.