[Lens] collapse by for partition charts #140336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
Team:Visualizations
drewdaemon
commented
Sep 8, 2022
| @@ -701,6 +701,7 @@ export type VisualizationDimensionGroupConfig = SharedDimensionProps & { | |||
| groupId: string; | |||
| accessors: AccessorConfig[]; | |||
| supportsMoreColumns: boolean; | |||
| dimensionsTooMany?: number; | |||
| /** If required, a warning will appear if accessors are empty */ | |||
| required?: boolean; | |||
| requiredMinDimensionCount?: number; | |||
There was a problem hiding this comment.
Follow-up: it looks like requiredMinDimensionCount is no longer used anywhere after #139214
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
flash1293
approved these changes
Sep 12, 2022
x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.tsx
Outdated
Show resolved
Hide resolved
…andrewctate/kibana into 137057/collapse-by-for-partition-charts
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.5.0
backport:skip
yngrdyn
pushed a commit
to yngrdyn/kibana
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #137057
Screen.Recording.2022-09-08.at.4.59.26.PM.mov
Checklist
Delete any items that are not applicable to this PR.