Stubs out UI for the ML Inference Pipeline panel #140456
Conversation
daveyholler
added
release_note:feature
…-ref HEAD~1..HEAD --fix'
…r/kibana into ent-search-ml-pipelines-panel
| * 2.0. | ||
| */ | ||
|
|
||
| export interface IInferencePipeline { |
There was a problem hiding this comment.
Can we remove the first I for purposes of consistency? It doesn't look like we use that convention anywhere else in the enterprise search Kibana code.
There was a problem hiding this comment.
But let's merge this first :)
|
@brianmcgue @sphilipse - the test file here currently only covers the individual inference pipeline cards. I know that this is blocking other work, so if we wanna get this merged and tackle test coverage in a follow up PR, I'm not personally opposed. Either way, this has been marked as ready for review. In the meantime, I'll try to get more code coverage in the test files. |
| export interface IInferencePipeline { | ||
| pipelineName: string; | ||
| trainedModelName: string; | ||
| isDeployed: boolean; | ||
| modelTypes: string[]; | ||
| } |
There was a problem hiding this comment.
I think for consistency's sake, we want to remove the first I from the interface name. Then modelTypes seems to be a combination of model_type and tags fields from the Get trained models API. Not sure if you want both or a specific one.
export interface InferencePipeline {
isDeployed: boolean;
modelType: string;
pipelineName: string;
tags: string[];
trainedModelName: string;
}…r/kibana into ent-search-ml-pipelines-panel # Conflicts: # x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/inference_pipeline_card.test.tsx
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/ml-ui (:ml) |
Summary
This PR gets the ML Inference Pipeline panel UI stubbed out. It also makes some modifications to the
data_panelcomponent in Enterprise Search:React.ReactNodeEuiFlexItems around so that thesubtitlecan go fullwidthChecklist
Delete any items that are not applicable to this PR.
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listFor maintainers