[Synthetics] prevent decryption errors from causing the entire suite of monitors to fail syncing

[dominiqueclarke]

Summary

Ensures that decryption errors are caught, so that a single monitor that is unable to be decrypted does not prevent the whole monitor suite from being synced.

Testing

1. Create at least two monitors
2. Deliberately introduce an unhandled exception during decryption. For example, you can add the following to the getDecryptedAsInternalUser

    return {
      getDecryptedAsInternalUser: async <T = unknown>(
        type: string,
        id: string,
        options?: SavedObjectsBaseOptions
      ): Promise<SavedObject<T>> => {
        areferenceerror; // force an error
        const [internalRepository, typeRegistry] = await internalRepositoryAndTypeRegistryPromise;
        const savedObject = await internalRepository.get(type, id, options);

        if (!service.isRegistered(savedObject.type)) {
          return savedObject as SavedObject<T>;
        }

        return {
          ...savedObject,
          attributes: (await service.decryptAttributes(
            {
              type,
              id,
              namespace: getDescriptorNamespace(typeRegistry, type, options?.namespace),
            },
            savedObject.attributes as Record<string, unknown>
          )) as T,
        };
      },

3. Ensure the monitor without error still runs as expected.

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)

[dominiqueclarke]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 675e3fc

Metrics [docs]

✅ unchanged

History

• 💔 Build #71753 failed b4e97d5
• 💚 Build #71548 succeeded 1de694f
• 💚 Build #71463 succeeded 42f0566

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation