Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Fix search query builder to generate wildcard query for keyword fields #140629

Merged
merged 1 commit into from Sep 16, 2022

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Sep 13, 2022

Summary

Resolves #23001.

Checklist

@dokmic dokmic marked this pull request as ready for review September 13, 2022 17:21
@dokmic dokmic requested a review from a team as a code owner September 13, 2022 17:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around with this and it looks to be working great! I'm just wondering if we consider this a breaking change as it changes query results. @sixstringcode What are your thoughts?

@sixstringcode
Copy link

Chatted with Micheal earlier, as explained in the issue this resolves, I don't see it as a breaking change.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 738.6KB 738.7KB +95.0B
apm 3.0MB 3.0MB +96.0B
canvas 1.0MB 1.0MB +95.0B
cloudSecurityPosture 200.9KB 201.0KB +96.0B
controls 458.5KB 458.6KB +95.0B
dashboard 366.5KB 366.6KB +95.0B
dataViewManagement 148.1KB 148.2KB +95.0B
dataVisualizer 566.6KB 566.7KB +95.0B
discover 471.3KB 471.4KB +95.0B
discoverEnhanced 43.8KB 43.9KB +95.0B
fleet 884.1KB 884.2KB +95.0B
graph 412.6KB 412.7KB +96.0B
infra 1017.0KB 1017.1KB +95.0B
inputControlVis 78.2KB 78.2KB +95.0B
lens 1.2MB 1.2MB +95.0B
lists 148.9KB 149.0KB +96.0B
ml 3.3MB 3.3MB +95.0B
monitoring 479.6KB 479.7KB +95.0B
observability 521.5KB 521.6KB +95.0B
osquery 1005.7KB 1005.8KB +95.0B
stackAlerts 100.6KB 100.7KB +95.0B
synthetics 986.0KB 986.1KB +95.0B
threatIntelligence 70.7KB 70.8KB +95.0B
transform 387.9KB 388.0KB +95.0B
triggersActionsUi 1.0MB 1.0MB +96.0B
unifiedFieldList 54.3KB 54.4KB +95.0B
unifiedSearch 260.3KB 260.4KB +95.0B
upgradeAssistant 179.7KB 179.8KB +96.0B
visTypeTimelion 108.5KB 108.6KB +95.0B
visTypeVega 1.7MB 1.7MB +95.0B
visualizations 198.4KB 198.5KB +95.0B
total +2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 42.9KB 42.9KB +95.0B
data 431.7KB 431.8KB +95.0B
maps 81.2KB 81.3KB +95.0B
securitySolution 261.0KB 261.1KB +95.0B
timelines 260.7KB 260.8KB +95.0B
total +475.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic merged commit 6932b71 into elastic:main Sep 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 16, 2022
@dokmic dokmic deleted the bugfix/23001 branch September 16, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:KQL KQL Feature:Search Querying infrastructure in Kibana release_note:fix review v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with wildcards, whitespace, and keyword fields in KQL
6 participants