Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix columns management of saved search embeddable #140799

Merged
merged 7 commits into from Sep 20, 2022
Merged

[Discover] Fix columns management of saved search embeddable #140799

merged 7 commits into from Sep 20, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Sep 15, 2022 •
edited

Summary

Fixes #140590

This PR fixes columns management in saved search embeddable.

Steps to reproduce:

  • Add a saved search to Dashboards
  • Try to change the order of columns
  • The change is ignored

@dimaanj dimaanj added Feature:Discover Discover Application release_note:fix auto-backport Deprecated: Automatically backport this PR after it's merged Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.5.0 v8.4.2 labels Sep 15, 2022
@dimaanj dimaanj added this to PRs in Discover via automation Sep 15, 2022
@dimaanj dimaanj self-assigned this Sep 15, 2022
@dimaanj dimaanj changed the title [Discover] fix manage of saved search embeddable columns [Discover] Fix columns management of saved search embeddable Sep 15, 2022
@dimaanj
Copy link
Contributor Author

dimaanj commented Sep 15, 2022

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Sep 15, 2022

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Sep 15, 2022

@elasticmachine merge upstream

@dimaanj dimaanj marked this pull request as ready for review September 15, 2022 16:11
@dimaanj dimaanj requested a review from a team as a code owner September 15, 2022 16:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for the quick fix, works as expected 👍 one ask, since we back port, a functional test for this would be awesome!

src/plugins/discover/public/embeddable/saved_search_embeddable.tsx Outdated Show resolved Hide resolved
@dimaanj
Copy link
Contributor Author

dimaanj commented Sep 20, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 477.3KB 477.4KB +42.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

kertal
kertal approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test again, since only renaming and a functional test was being added. Thx for the adaptations and fixing it that quickly! 💟

@dimaanj dimaanj merged commit 3c5b3f3 into elastic:main Sep 20, 2022
Discover automation moved this from PRs to Done Sep 20, 2022
kibanamachine pushed a commit that referenced this pull request Sep 20, 2022
@dimaanj
[Discover] Fix columns management of saved search embeddable (#140799)
10b4016 
* [Discover] fix manage of saved search embeddable columns

* [Discover] add functional test

* [Discover] rename function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3c5b3f3)
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Sep 20, 2022
@kibanamachine @dimaanj
[Discover] Fix columns management of saved search embeddable (#140799) (
69ab3ea 
#141051)

* [Discover] fix manage of saved search embeddable columns

* [Discover] add functional test

* [Discover] rename function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3c5b3f3)

Co-authored-by: Dmitry Tomashevich <39378793+dimaanj@users.noreply.github.com>
@tylersmalley
Copy link
Contributor

This PR missed the 8.4.2 release, so I have updated the labels to reflect this.

@kertal kertal mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.4.3 v8.5.0
Projects
No open projects
Discover
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Embeddable doesn't allow editing columns
6 participants
@dimaanj @elasticmachine @kibana-ci @kibanamachine @tylersmalley @kertal