Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Fix responsive styles of field manager #140948

Merged
merged 1 commit into from Sep 19, 2022
Merged

[Graph] Fix responsive styles of field manager #140948

merged 1 commit into from Sep 19, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 19, 2022 •
edited by kibanamachine

Closes #105543

Summary

This PR fixes Flex styles so items wrap.

Sep-19-2022 14-56-53

@jughosta jughosta added release_note:fix Feature:Graph Graph application feature Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 19, 2022
@jughosta jughosta self-assigned this Sep 19, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 450.0KB 450.0KB +22.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review September 19, 2022 14:14
@jughosta jughosta requested a review from a team as a code owner September 19, 2022 14:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

davismcphee
davismcphee approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review (trusting the GIF) LGTM 👍

@jughosta jughosta merged commit 7a1934f into elastic:main Sep 19, 2022
@jughosta jughosta deleted the 105543-graph-cta branch September 19, 2022 16:41
@kibanamachine kibanamachine mentioned this pull request Sep 19, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2022
@jughosta
[Graph] Fix responsive styles of field manager (elastic#140948)
a5e4beb 
(cherry picked from commit 7a1934f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 19, 2022
@kibanamachine @jughosta
[Graph] Fix responsive styles of field manager (#140948) (#140982)
9e76b8a 
(cherry picked from commit 7a1934f)

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
@tylersmalley
Copy link
Contributor

This PR missed the 8.4.2 release, so I have updated the labels to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:Graph Graph application feature release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.4.3 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Graph] Adding many fields can result in the CTA to go off the screen
6 participants
@jughosta @kibana-ci @elasticmachine @kibanamachine @tylersmalley @davismcphee