Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Fix positioning of Add fields popover #141040

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[Graph] Fix positioning of Add fields popover #141040

merged 2 commits into from
Sep 20, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 20, 2022 •
edited by kibanamachine
Loading

Closes #85009

Summary

This PR fixes the popovers position.

Before:
Screenshot 2022-09-20 at 10 59 17

After:
Screenshot 2022-09-20 at 10 58 53

@jughosta jughosta added release_note:fix Feature:Graph Graph application feature Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 20, 2022
@jughosta jughosta self-assigned this Sep 20, 2022
@jughosta jughosta marked this pull request as ready for review September 20, 2022 10:04
@jughosta jughosta requested a review from a team as a code owner September 20, 2022 10:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice little fix 👍 , works as expected. One question, would that also make sense for the edit functionality for the selected fields?

Bildschirmfoto 2022-09-20 um 12 55 16

it's just displayed this way on the first field

@jughosta
Copy link
Contributor Author

@kertal Done! Thanks for the idea!

Screenshot 2022-09-20 at 13 00 55

@kertal
Copy link
Member

kertal commented Sep 20, 2022

@kertal Done! Thanks for the idea!

Screenshot 2022-09-20 at 13 00 55

thx for implementing it so quickly! URJD! Ultra-rapid-jughosta development ! tested an works as expected

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 450.1KB 450.1KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit 3487e3a into elastic:main Sep 20, 2022
@jughosta jughosta deleted the 85009-graph-add-fields-popover branch September 20, 2022 12:09
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2022
@jughosta
[Graph] Fix positioning of Add fields popover (elastic#141040)
fd7a4e2 
* [Graph] Fix positioning of Add fields popover

* [Graph] Fix positioning of Edit field popover

(cherry picked from commit 3487e3a)
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 20, 2022
@kibanamachine @jughosta
[Graph] Fix positioning of Add fields popover (#141040) (#141068)
79b1d94 
* [Graph] Fix positioning of Add fields popover

* [Graph] Fix positioning of Edit field popover

(cherry picked from commit 3487e3a)

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
@tylersmalley
Copy link
Contributor

This PR missed the 8.4.2 release, so I have updated the labels to reflect this.

@jughosta
Copy link
Contributor Author

@tylersmalley Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:Graph Graph application feature release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.4.3 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fields panel on create graph page is getting displayed on graph->unsaved graph breadcrumb
6 participants
@jughosta @elasticmachine @kertal @kibana-ci @kibanamachine @tylersmalley