[Guided onboarding] Updated the examples #141265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the active step check
yuliacech
added
release_note:fix
v8.5.0
Team:Journey/Onboarding
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
There was a problem hiding this comment.
Thanks for updating this! Left one comment around changing the step ID due to the updated config changes made in #141233.
|
|
||
| const [isTourStepOpen, setIsTourStepOpen] = useState<boolean>(false); | ||
|
|
||
| useEffect(() => { | ||
| const subscription = guidedOnboardingApi | ||
| ?.isGuideStepActive$('search', 'search_experience') |
There was a problem hiding this comment.
I this this may need to change to browse_docs based on the changes I made in https://github.com/elastic/kibana/pull/141233/files
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Sep 27, 2022
…or the active step check (elastic#141265)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following a conversation with @stephmilovic, I updated the examples to only use the Observable for the active step state.