Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] run unit tests in series again #141481

Merged
merged 3 commits into from Sep 23, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 22, 2022

Assists with #141477

@elastic/apm-ui folks, I needed to skip a test to make this work. More details here: #141543

Reduce the concurrency of jest unit tests back to 1 by running tests in band. It seems like react-dom/test-utils is constantly breaking Jest workers by trying to fire click events after jsdom is torn-down, leading to exceptions and flaky failures.

In researching solutions for #115307 we identified that CPU load leads to this race condition triggering more often, so I'm hoping that reducing the concurrency of our tests can help us reduce the annoyance of flaky Jest tests until jestjs/jest#12670 is resolved or we find some other workaround.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Sep 23, 2022
@spalger spalger marked this pull request as ready for review September 23, 2022 01:57
@spalger spalger requested review from a team as code owners September 23, 2022 01:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 23, 2022
@spalger spalger merged commit 5d12b57 into elastic:main Sep 23, 2022
@spalger spalger deleted the run-jest-tests-in-series branch September 23, 2022 13:02
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Operations Team label for Operations Team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants