Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] hide/show all layers #141495

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[Maps] hide/show all layers #141495

merged 3 commits into from
Sep 26, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 22, 2022

Add "show all layers" and "hide all layers" button to legend. Hide all layers hides all non-basemap layers.

Screen Shot 2022-09-22 at 12 05 19 PM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.6.0 labels Sep 22, 2022
@nreese nreese marked this pull request as ready for review September 22, 2022 20:46
@nreese nreese requested a review from a team as a code owner September 22, 2022 20:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jsanz jsanz added the ci:cloud-deploy Create or update a Cloud deployment label Sep 23, 2022
@jsanz
Copy link
Member

jsanz commented Sep 23, 2022

@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tested in chrome and code review

@nreese
Copy link
Contributor Author

nreese commented Sep 26, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 26, 2022 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit fbf343a into elastic:main Sep 26, 2022
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Sep 27, 2022
@nreese @kibanamachine @jennypavlova
[Maps] hide/show all layers (elastic#141495)
20b9bc0 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@KOTungseth KOTungseth added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nreese @elasticmachine @jsanz @kibana-ci @nickpeihl @KOTungseth @kibanamachine