You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates another, more specific, BrowserFields type that matches with the object used by the Field Browser component. (you can find the current BrowserFields definition here )
As the BrowserField type is being used in multiple places in throughout multiple plugins a mapper function that converts from the old BrowserField type to the new BrowserField type.
Every where we make use of the Field Browser component we convert from the old type to the new one, for example here
To discuss:
We think that the right way would be to only have type of Browser Field so we would like to discuss about which one would be the better fit and in case we decide to move towards the new definition, what the next steps would be.
QA - The fields browser feature in the alerts table should be working as before. You'll find this feature in Security Solution >> Alerts and in Observability >> Overview
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #141187
Blocked by #141385MergedWhat this PR does:
To discuss:
QA - The fields browser feature in the alerts table should be working as before. You'll find this feature in Security Solution >> Alerts and in Observability >> Overview