-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ILM jest tests as integration tests allowing them to run beyond 5s timeout #141750
Conversation
@elasticmachine merge upstream |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thank you @Dosant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for doing this @Dosant !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Thanks for addressing this @Dosant!
One small request 😄 What do you think about updating the README
with some background information around these tests and why they were moved to integration_tests
? The deployment management team owns many apps with similar testing infrastructure, and I could see someone coming back to the code confused why ILM follows a slightly different pattern.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…s timeout (elastic#141750) (cherry picked from commit 0471095)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
fix #141645
fix #141160
fix #115307
ILM heavy unit tests are flaky and can fail with a 5-second timeout. It happened in the past but it looks like it got worse with newly added features (#140804, #138748). (I assume that the problem is not specific to the new code, but just caused by adding more code)
We could have increased the timeout manually, but @spalger suggested to run these tests as integration tests. Here Spencer also explains the differences: