New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es/clusters] improve cleanup #14188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Team label for Operations Team
review
v6.1.0
v7.0.0
labels
Sep 27, 2017
spalger
force-pushed
the
fix/es-clusters/shutdown
branch
from
September 27, 2017 23:37
1b192b0
to
1d80b52
Compare
tylersmalley
approved these changes
Oct 3, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jbudz mind taking a look? |
jbudz
approved these changes
Oct 30, 2017
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 30, 2017
* [es/clusters] automatically close all clusters on server close * [es/cluster] track and close all created clients * [es/clusters] remove old close tests
spalger
added a commit
that referenced
this pull request
Oct 30, 2017
tylersmalley
added
release_note:fix
release_note:enhancement
and removed
release_note:fix
labels
Nov 16, 2017
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
* [es/clusters] automatically close all clusters on server close * [es/cluster] track and close all created clients * [es/clusters] remove old close tests
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
* [es/clusters] automatically close all clusters on server close * [es/cluster] track and close all created clients * [es/clusters] remove old close tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the elasticsearch plugin's
Clusters
class to automatically call.close()
on everyCluster
it creates, and updates theCluster
class to automatically call.close()
on every client they create.