Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] [@kbn/tinymath] Add new defaults function #142087

Merged
merged 9 commits into from
Oct 5, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 28, 2022

Summary

Closes #140829

This PR introduces a new defaults function, useful to gracefully fallback from missing values.

I'm not really super happy about the doc here, as there's no other mention of null in any other tinymath function in the doc. 🤔

The new function has been documented also on the Lens Formula side.

Screenshot 2022-09-28 at 14 35 32

defaults_formula

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 28, 2022
@dej611 dej611 marked this pull request as ready for review September 30, 2022 16:53
@dej611 dej611 requested a review from a team as a code owner September 30, 2022 16:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@dej611 dej611 requested a review from cqliu1 September 30, 2022 16:53
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works as expected

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1152 1153 +1
expressions 172 173 +1
lens 922 923 +1
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +176.0B
expressions 25.6KB 25.7KB +170.0B
lens 1.3MB 1.3MB +631.0B
total +977.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 4d72685 into elastic:main Oct 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
* ✨ Add new defaults function

* ✨ Add new defaults function

* 📝 Rewrite the doc

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
* ✨ Add new defaults function

* ✨ Add new defaults function

* 📝 Rewrite the doc

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Math operation in formula nulls if any of the operations has null results
5 participants