Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expressions] Fix expressions chain invocation not to stop on partial results error #142105

Merged
merged 1 commit into from Sep 29, 2022

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Sep 28, 2022

Summary

Resolves #141673.

Release note

Fixed expressions executor stopping on failing partially emitted result. The bug was causing errors in some datatable functions following the esdocs and essql functions.

Checklist

@dokmic dokmic force-pushed the bugfix/141673 branch 2 times, most recently from 717e61e to eb0db1b Compare September 28, 2022 13:54
@dokmic dokmic marked this pull request as ready for review September 28, 2022 14:34
@dokmic dokmic requested a review from a team as a code owner September 28, 2022 14:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 97.3KB 97.3KB +50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic removed the v8.4.3 label Sep 29, 2022
@dokmic dokmic merged commit 6a0b2fd into elastic:main Sep 29, 2022
@dokmic dokmic deleted the bugfix/141673 branch September 29, 2022 06:39
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 29, 2022
…error (#142105) (#142184)

(cherry picked from commit 6a0b2fd)

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
@dokmic dokmic added the v8.4.3 label Sep 29, 2022
@dokmic
Copy link
Contributor Author

dokmic commented Sep 29, 2022

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dokmic added a commit to dokmic/kibana that referenced this pull request Sep 29, 2022
dokmic added a commit that referenced this pull request Sep 29, 2022
@mistic
Copy link
Member

mistic commented Oct 5, 2022

This PR missed the 8.4.3 release, so I have updated the labels to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Expressions] Execution should not stop with an error on partial results
6 participants