Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K7][UI Framework]: Pagination rows example, text style for ButtonEmpty #14219

Merged
merged 2 commits into from Sep 29, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Sep 29, 2017

This PR adds the following:

  • Examples for how to handle a rows per page "dropdown". Examples added both to pagination docs and to context menu.
  • Assorted icons, including an "empty" icon. One that is an empty SVG that can take the place of an real icon when you need to line things up.
  • A new type for KuiButtonEmpty called "text" which styles a button like normal text (this is good for repetitive links like pagination or navigation).
  • Some cleanup of pagination CSS to use the above, more modular components.

TODO in a non-breaking followup PR

  • Figure out a method to color the popover "arrow" when titles aren't used.

image

@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Sep 29, 2017
id: 0,
items: [{
name: '10 rows',
icon: 'empty',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cheat, but I think one we'll likely need over and over again. Sometimes you want to line up a row of items, and only show an icon (say a check) on the active row. While you could toggle classes to achieve the same thing, it's much easier (and scalable) to just have an "empty" icon which takes up the space of an icon, but contains no real content.

image

@cjcenizal
Copy link
Contributor

FYI I've simplified the KuiContextMenu's interface for cases where you only need a single panel in https://github.com/elastic/kibana/pull/14183/files#diff-f821d1d03e3b86a67081d403bcca5003R66. When that's merged I'll rebase the K7 branch and update the example introduced by this PR.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁 LGTM

@snide snide merged commit d16e215 into elastic:k7-ui-framework Sep 29, 2017
@snide snide deleted the k7/pagination_rows branch September 29, 2017 16:58
@chrisronline
Copy link
Contributor

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants