Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Show an info callout for new notifications #142245

Merged
merged 6 commits into from Sep 30, 2022
Merged

[ML] Show an info callout for new notifications #142245

merged 6 commits into from Sep 30, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Sep 29, 2022 •
edited

Summary

image

Checklist

@darnautov darnautov self-assigned this Sep 29, 2022
@darnautov darnautov marked this pull request as ready for review September 30, 2022 13:31
@darnautov darnautov requested a review from a team as a code owner September 30, 2022 13:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member

qn895 commented Sep 30, 2022

Code LGTM 🎉

@darnautov darnautov enabled auto-merge (squash) September 30, 2022 15:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1621 1622 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +790.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 874c93c into elastic:main Sep 30, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 30, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 2, 2022
@darnautov @WafaaNasr
[ML] Show an info callout for new notifications (elastic#142245)
5d92ad4 
* storage context callbacks

* ml notifications context

* ml notifications context usage

* info callout

* update icon

* add unit tests
@darnautov darnautov mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@darnautov @elasticmachine @qn895 @kibana-ci @peteharverson @kibanamachine