Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] [Annotations] Update label for Time field #142452

Merged
merged 3 commits into from Oct 3, 2022
Merged

[TSVB] [Annotations] Update label for Time field #142452

merged 3 commits into from Oct 3, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 3, 2022 •
edited

Closes: #142226

Summary

What was done:

  • updated Time Field (required) -> Time Field
  • Added a placeholder with default time field of selected Data View instead of Select field ...

@alexwizp alexwizp self-assigned this Oct 3, 2022
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) v8.6.0 release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:skip This commit does not require backporting labels Oct 3, 2022
@alexwizp alexwizp marked this pull request as ready for review October 3, 2022 12:01
@alexwizp alexwizp requested a review from a team as a code owner October 3, 2022 12:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only. 👍
Just left a minor comment about function content readability, suggested alternative implementation.

...lugins/vis_types/timeseries/public/application/components/aggs/field_select/field_select.tsx Outdated Show resolved Hide resolved
alexwizp and others added 2 commits October 3, 2022 15:11
@alexwizp @dej611
Update src/plugins/vis_types/timeseries/public/application/components…
265235f 
…/aggs/field_select/field_select.tsx

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
95129a6 
…-ref HEAD~1..HEAD --fix'
@alexwizp alexwizp enabled auto-merge (squash) October 3, 2022 12:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 493.5KB 493.7KB +180.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit a8d54b3 into elastic:main Oct 3, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@alexwizp @dej611
@kibanamachine @WafaaNasr
[TSVB] [Annotations] Update label for Time field (elastic#142452)
df69f21 
* [TSVB] [Annotations] Update label for Time field

Closes: elastic#142226

* Update src/plugins/vis_types/timeseries/public/application/components/aggs/field_select/field_select.tsx

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@alexwizp @dej611
@kibanamachine @WafaaNasr
[TSVB] [Annotations] Update label for Time field (elastic#142452)
81685f9 
* [TSVB] [Annotations] Update label for Time field

Closes: elastic#142226

* Update src/plugins/vis_types/timeseries/public/application/components/aggs/field_select/field_select.tsx

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] [Annotations] Update label for Time field
5 participants
@alexwizp @elasticmachine @kibana-ci @dej611 @kibanamachine