Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XY] Fixes the detailed tooltip wrap problem #142818

Merged
merged 6 commits into from Oct 10, 2022
Merged

[XY] Fixes the detailed tooltip wrap problem #142818

merged 6 commits into from Oct 10, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 6, 2022 •
edited

Summary

Closes #142759

Fixes the wrap problem on the detailed tooltip of the aggregate based visualizations.

Before
Screenshot 2022-10-06 at 10 32 18 AM

After
image

Tested this on Chrome, Safari and FF and works fine.

Checklist

@stratoula stratoula added release_note:fix Feature:XYAxis XY-Axis charts (bar, area, line) backport:skip This commit does not require backporting v8.6.0 labels Oct 6, 2022
@stratoula stratoula marked this pull request as ready for review October 6, 2022 08:50
@stratoula stratoula requested a review from a team as a code owner October 6, 2022 08:50
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

mbondyra
mbondyra approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

MichaelMarcialis
MichaelMarcialis approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @stratoula! I've left you a few comments and suggestions for your review. Assuming you're able to implement those suggestions, I'm going to approve this now (as I'll be out on PTO next week and I don't want to leave you blocked). Let me know if you have any questions. Thanks!

src/plugins/chart_expressions/expression_xy/public/components/tooltip/tooltip.scss Outdated Show resolved Hide resolved
src/plugins/chart_expressions/expression_xy/public/components/tooltip/tooltip.scss Show resolved Hide resolved
src/plugins/chart_expressions/expression_xy/public/components/tooltip/tooltip.scss Outdated Show resolved Hide resolved
@stratoula
Copy link
Contributor Author

Thanx @MichaelMarcialis! I addressed all your comments and it works fine!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 118.4KB 118.5KB +120.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit d7924aa into elastic:main Oct 10, 2022
@rpasche
Copy link

rpasche commented Oct 11, 2022 •
edited

@stratoula Could you please backport this to 8.4.x and 8.5.x?

WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@stratoula @WafaaNasr
[XY] Fixes the detailed tooltip wrap problem (elastic#142818)
c857e94 
* [XY] Fixes the detailed tooltip wrap problem

* Add max width to the label container

* Apply PR comments
@timductive
Copy link
Member

@rpasche we can backport to 8.5.x as we are still doing patch releases there.

@stratoula stratoula mentioned this pull request Oct 11, 2022
Merged
@stratoula
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Oct 11, 2022
@stratoula
[XY] Fixes the detailed tooltip wrap problem (elastic#142818)
cc1ff9f 
* [XY] Fixes the detailed tooltip wrap problem

* Add max width to the label container

* Apply PR comments

(cherry picked from commit d7924aa)
stratoula added a commit that referenced this pull request Oct 11, 2022
@stratoula
[XY] Fixes the detailed tooltip wrap problem (#142818) (#143087)
fb34b60 
* [XY] Fixes the detailed tooltip wrap problem

* Add max width to the label container

* Apply PR comments

(cherry picked from commit d7924aa)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@stratoula @WafaaNasr
[XY] Fixes the detailed tooltip wrap problem (elastic#142818)
ff89910 
* [XY] Fixes the detailed tooltip wrap problem

* Add max width to the label container

* Apply PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:XYAxis XY-Axis charts (bar, area, line) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detailed tooltip cut off on long field names
8 participants
@stratoula @elasticmachine @kibana-ci @rpasche @timductive @MichaelMarcialis @mbondyra @kibanamachine