[APM] Remove check for infra data #142835
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
| /> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure why we even need our own empty state message. I assume the logs component itself has one It does.
There was a problem hiding this comment.
Yes thanks. I didn't say "just remove it" in the issue in case there were other implications I wasn't understanding but this looks like it does the right thing.
There was a problem hiding this comment.
I don't recall the reason for us to have a separate no-data screen. Maybe we can load it faster, or perhaps we wanted it to look like our other views. But those are lesser concerns compared to actually being able to see the logs.
sorenlouv
force-pushed
the
show-logs-regardless-of-infra-metric-data
branch
2 times, most recently
from
3778b57
to
25ec17b
Compare
sorenlouv
force-pushed
the
show-logs-regardless-of-infra-metric-data
branch
from
25ec17b
to
58e4dfc
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
(cherry picked from commit b3cfd97)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sorenlouv
added
v8.4.0
auto-backport
(cherry picked from commit b3cfd97)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Close #142656
This PR removes the "no-data" check since it was overly restrictive. Now we always try to show the logs component and rely on its own no-data check. Below is an example of how the no-data check has changed slightly.
Before (APM UI no-data check)
After (Logs no-data check)