Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DESIGN]: Remove truncate from viz form text, remove additional wrapper #14311

Merged
merged 3 commits into from Oct 5, 2017
Merged

[DESIGN]: Remove truncate from viz form text, remove additional wrapper #14311

merged 3 commits into from Oct 5, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Oct 4, 2017

Addresses #14301

  • Removes text-overflow / nowrap on the labels so they can't get cut off.
  • Removes extraneous sidebar wrapper which was messing up spacing in lots of places. Adds wrappers per section, so there is better definition.

image

@snide
Copy link
Contributor Author

snide commented Oct 4, 2017

@thomasneirynck The panels should be added per "section" you want to wrap and not over the whole content. Here's an example showing off the sectioning. I went through all the vis types that I could find and adjusted their forms, but give it a check just in case I missed something.

image

@snide
Copy link
Contributor Author

snide commented Oct 4, 2017

cc @alexfrancoeur since he requested the fix.

@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Oct 4, 2017
@alexfrancoeur
Copy link

Having some issues pulling down directly and can try again tomorrow. The screenshots look great and I love the separate sections as well.

thomasneirynck
thomasneirynck approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, looks nice! thx!

I have one minor suggestion, and that is to remove the Options header. Since these are always listed on the options tab, it looks a little redundant.

here's an example of this:
image

src/core_plugins/region_map/public/region_map_vis_params.html Outdated
<div class="kuiSideBarSectionTitle__text">
Layer Settings
</div>
<div class="kuiSideBarSectionTitle__text">Options</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should just strip this. imho looks better without

image

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html Outdated
<div>
<div class="kuiSideBarSection">
<div class="kuiSideBarSectionTitle">
<div class="kuiSideBarSectionTitle__text">Options</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too. there's a couple of other places as well ..

@snide
Copy link
Contributor Author

snide commented Oct 4, 2017

Cleaned those up @thomasneirynck. Good eye.

@snide snide merged commit 330665b into elastic:master Oct 5, 2017
@snide snide deleted the viz_overflow branch October 5, 2017 17:33
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Oct 5, 2017
@snide @thomasneirynck
[DESIGN]: Remove truncate from viz form text, remove additional wrapp…
6a68764 
…er (elastic#14311)

* remove truncate from viz form text, remove additional wrapper

* fix section paneling within viz

* remove redundant titling
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 5, 2017 •
edited

Backports:
6.x: #14336
6.0: #14337 (with manual edits)

thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Oct 5, 2017
@snide @thomasneirynck
[DESIGN]: Remove truncate from viz form text, remove additional wrapp…
c41cfc9 
…er (elastic#14311)

* remove truncate from viz form text, remove additional wrapper

* fix section paneling within viz

* remove redundant titling
@thomasneirynck thomasneirynck mentioned this pull request Oct 5, 2017
Merged
thomasneirynck added a commit that referenced this pull request Oct 5, 2017
@thomasneirynck
[DESIGN]: Remove truncate from viz form text, remove additional wrapp…
9e830eb 
…er (#14311) (#14336)

* remove truncate from viz form text, remove additional wrapper

* fix section paneling within viz

* remove redundant titling
thomasneirynck added a commit that referenced this pull request Oct 5, 2017
@thomasneirynck
[DESIGN]: Remove truncate from viz form text, remove additional wrapp…
f700d9c 
…er (#14311) (#14337)

* remove truncate from viz form text, remove additional wrapper

* fix section paneling within viz

* remove redundant titling
@thomasneirynck thomasneirynck mentioned this pull request Oct 5, 2017
Closed
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
@snide @chrisronline
[DESIGN]: Remove truncate from viz form text, remove additional wrapp…
a8aed23 
…er (elastic#14311)

* remove truncate from viz form text, remove additional wrapper

* fix section paneling within viz

* remove redundant titling
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
@snide @chrisronline
[DESIGN]: Remove truncate from viz form text, remove additional wrapp…
9136a2f 
…er (elastic#14311)

* remove truncate from viz form text, remove additional wrapper

* fix section paneling within viz

* remove redundant titling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snide @alexfrancoeur @thomasneirynck