Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens]Adds selected field accordion to the fields list #143175

Merged
merged 2 commits into from Oct 12, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 12, 2022

Summary

Closes #141916

Displays a new section "Selected fields" on the fields list for both the formBased and textBased datasources.

TextBased

  • I created 2 accordion groups (available and selected)
  • Selected is displayed when there are used fields on the layers
  • I added a badge with the fields count on each group (to be aligned with the formBased datasource)

image

FormBased

  • I added one accordion group "Selected fields"
  • Selected is displayed when there are used fields on the layers

image

Checklist

@stratoula stratoula changed the title [Lens]Add selected field accordion to the fields list [Lens]Adds selected field accordion to the fields list Oct 12, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 925 926 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +2.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added v8.6.0 release_note:enhancement backport:skip This commit does not require backporting Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 12, 2022
@stratoula stratoula marked this pull request as ready for review October 12, 2022 13:13
@stratoula stratoula requested a review from a team as a code owner October 12, 2022 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM.

I'm not 100% sure about the interaction for text based languages, but that's something we can iterate on later on as well.

It's definitely helpful to see very easily whether some columns are unmapped for now.

@stratoula stratoula merged commit e877fbf into elastic:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Show selected fields in special section in accordion
4 participants