Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB][Lens] Added support of Variance aggregation for navigate to lens #143209

Conversation

VladLasitsa
Copy link
Contributor

Summary

Completes part of #138236

Added support of 'Variance' aggregation. This aggregation convert to formula - pow(standard_deviation(fieldName), 2)

TSVB:
Снимок экрана 2022-10-12 в 18 13 43

After conversion in Lens:
Снимок экрана 2022-10-12 в 18 14 10

@VladLasitsa VladLasitsa self-assigned this Oct 12, 2022
@VladLasitsa VladLasitsa added release_note:enhancement Feature:TSVB TSVB (Time Series Visual Builder) Feature:Lens backport:skip This commit does not require backporting v8.6.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 12, 2022
@VladLasitsa VladLasitsa marked this pull request as ready for review October 13, 2022 10:40
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 13, 2022 10:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor

stratoula commented Oct 14, 2022

Why don't we allow the transition for moving average?

It can be moving_average(pow(standard_deviation(machine.ram), 2))

Same question for Derivative.

@VladLasitsa
Copy link
Contributor Author

VladLasitsa commented Oct 14, 2022

Why don't we allow the transition for moving average?

It can be moving_average(pow(standard_deviation(machine.ram), 2))

Same question for Derivative.

@stratoula good catch! Forgot to add new case for converting parent pipeline aggs. Fixed.

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine now, LGTM

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 379 380 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 502.6KB 503.2KB +590.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa merged commit 3cf9778 into elastic:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants