Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Moment.js timezone error when defining a range filter #143213

Merged
merged 4 commits into from Oct 17, 2022
Merged

fix Moment.js timezone error when defining a range filter #143213

merged 4 commits into from Oct 17, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 12, 2022

Summary

fix #143195

This is what the original code was fixing:
#45266

Needs special handling for Browser value. Copied the snippet from other places.
In general, I am not sure about the original issue and the fix , but didn't look into the logic of it. just fixing the timezone error

@Dosant Dosant marked this pull request as ready for review October 12, 2022 15:57
@Dosant Dosant requested a review from a team as a code owner October 12, 2022 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant
Copy link
Contributor Author

Dosant commented Oct 13, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Oct 13, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Oct 17, 2022

@elasticmachine merge upstream

@Dosant Dosant enabled auto-merge (squash) October 17, 2022 08:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 261.7KB 261.7KB +40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 891e587 into elastic:main Oct 17, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 17, 2022
guskovaue pushed a commit to guskovaue/kibana that referenced this pull request Oct 22, 2022
@Dosant @guskovaue
fix Moment.js timezone error when defining a range filter (elastic#14…
7b4cff1 
…3213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Filters Feature:Unified search Unified search related tasks release_note:fix v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moment.js timezone error when defining a filter in Firefox
5 participants
@Dosant @elasticmachine @kibana-ci @lukasolson @kibanamachine