Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Add ability to invert color ramp and size #143307

Merged
merged 15 commits into from Oct 24, 2022
Merged

[Maps] Add ability to invert color ramp and size #143307

merged 15 commits into from Oct 24, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 13, 2022 •
edited

Fixes #34478

PR allows for inverting styling. PR also converts some styling files to TS.

Lighter shades symbolize larger requests, and darker shades symbolize smaller requests
Screen Shot 2022-10-12 at 4 36 50 PM

Larger circle symbolize requests early in the day, smaller circles symbolize requests latter in the day.
Screen Shot 2022-10-13 at 11 40 47 AM

@nreese
Copy link
Contributor Author

nreese commented Oct 13, 2022

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review October 13, 2022 22:30
@nreese nreese requested a review from a team as a code owner October 13, 2022 22:30
@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.6.0 labels Oct 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jsanz jsanz added the ci:cloud-deploy Create or update a Cloud deployment label Oct 17, 2022
@jsanz
Copy link
Member

jsanz commented Oct 17, 2022

@elasticmachine merge upstream

@jsanz
Copy link
Member

jsanz commented Oct 17, 2022

Tested on different layer types and this is so great 🥰 I'm sure our users will welcome it heartily.

Would it be possible to also have this available for the heatmap layer?

nickpeihl
nickpeihl approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great feature! I added a few nits, but overall lgtm!

code review and tested in chrome

Nit: In the conversion from JS to TS, we often have to import types to define props. I'm not certain this is the case, but using import type (example: import type { DynamicSizeProperty}) might compile slightly faster since the runtime compiler should ignore type imports.

x-pack/plugins/maps/public/classes/styles/color_palettes.test.ts Show resolved Hide resolved
x-pack/plugins/maps/public/classes/styles/vector/components/legend/marker_size_legend.tsx Outdated Show resolved Hide resolved
...maps/public/classes/styles/vector/properties/dynamic_size_property/dynamic_size_property.tsx Outdated Show resolved Hide resolved
@nreese
Copy link
Contributor Author

nreese commented Oct 24, 2022

Would it be possible to also have this available for the heatmap layer?

Yes, but since its a different implementation I was going to split it out into a separate effort.

@nreese
Copy link
Contributor Author

nreese commented Oct 24, 2022

@elasticmachine merge upstream

@nreese nreese requested a review from nickpeihl October 24, 2022 19:26
nickpeihl
nickpeihl approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 24, 2022 •
edited

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit ee32659 into elastic:main Oct 24, 2022
@KOTungseth KOTungseth added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Add ability to invert color ramp
7 participants
@nreese @elasticmachine @jsanz @kibana-ci @nickpeihl @KOTungseth @kibanamachine