[ML] Calculate model memory limit for Lens created jobs #143456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kc13greiner
pushed a commit
to kc13greiner/kibana
that referenced
this pull request
Oct 19, 2022
* [ML] Calculate model memory limit for Lens created jobs * check for indices * more checks * adding test
guskovaue
pushed a commit
to guskovaue/kibana
that referenced
this pull request
Oct 22, 2022
* [ML] Calculate model memory limit for Lens created jobs * check for indices * more checks * adding test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a job from a Lens visualization, we should use the calculate model memory limit api so the default value of
1024mbis not used.The calculation happens when the user presses the create button, before the job is saved.
If for some reason the calculation fails, the error is ignored (logged to the browser's console) and the job creation continues with the default value.
Fixes #143451